Skip to content

Prevent unnecessary updates and feature detection#22

Open
myfonj wants to merge 3 commits into
eqcss:gh-pagesfrom
myfonj:unified-setStyle
Open

Prevent unnecessary updates and feature detection#22
myfonj wants to merge 3 commits into
eqcss:gh-pagesfrom
myfonj:unified-setStyle

Conversation

@myfonj

@myfonj myfonj commented Jul 14, 2016

Copy link
Copy Markdown
  • Introduce EQCSS.setStyle method according browser capabilities to overcome feature detection.
  • Prevent resetting styles without changes.

This should increase performance, and from my testing really "feels" significantly snappier :]

myfonj and others added 2 commits July 14, 2016 21:30
- Introduce EQCSS.setStyle method according browser capabilities to overcome feature detection.
- Prevent resetting styles without changes.

This should increase performance, and from my testing really "feels" significantly snappier :]
@tomhodgins

Copy link
Copy Markdown
Contributor

Hi @myfonj, Thanks for the contribution!

I've just created a 1.3.0 branch for this and a scroll fix I've been testing. Do you know how I could pull this into the 1.3.0 branch instead of into the gh-pages branch?

Fix scrolling on BODY or HTML elements IE9+
@myfonj

myfonj commented Jul 14, 2016

Copy link
Copy Markdown
Author

Oh, hi, thanks for kind response.

TBH I suck at git(hub): this was my first pull request ever -- realized that GH-pages would not be proper branch just after pressing "confirm", what a failure X|.

Seems that rebasing pull request is not possible, although quite demanded, so apparently the only option is closing this one and pulling (or cherrypicking (omg)) with another. (I've merged your 1.3.0 there without problem so I assume it should pass.) You can do it yourself now or I could open new request. Or ignore this and cram changes there manually: I wouldn't mind the missing link, and in fact I think maybe you'd like to change it anyway (eg that initialization in the domReady could be probably elsewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants