Add espnet2 and espnet3 to check_install.py module list#6435
Open
Copilot wants to merge 4 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/espnet/espnet/sessions/736f6b28-0ffc-41c3-84bd-4f8ffb2cebe7 Co-authored-by: Fhrozen <11988996+Fhrozen@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Fhrozen
May 8, 2026 23:28
View session
Member
|
Fixes #6419 |
Fhrozen
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6419
Summary
As suggested in #6419 (comment), add
espnet2andespnet3entries to themodule_listintools/check_install.py, right after the existingespnetentry.This allows
check_install.pyto report whetherespnet2andespnet3are importable, which is useful sinceespnetitself may not be importable in newer releases (onlyespnet2/espnet3remain as primary packages).Changes
tools/check_install.py: add("espnet2", None, None)and("espnet3", None, None)tomodule_list