Replace broken via.placeholder.com with placehold.co#3278
Open
sawirricardo wants to merge 1 commit into
Open
Conversation
via.placeholder.com domain is no longer resolving. Replace with
placehold.co which provides the same placeholder image service.
URL format updated to match placehold.co's structure:
- Without colors: placehold.co/{size}.{format}
- With background: placehold.co/{size}/{bg}.{format}
- With bg + text color: placehold.co/{size}/{bg}/{text}.{format}
Closes faker-ruby#3055
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
via.placeholder.comdomain is no longer resolving, causingFaker::Placeholditto generate broken image URLs.This PR replaces it with placehold.co, a working placeholder image service with a similar API.
Fixes #3055
Changes
lib/faker/default/placeholdit.rb: Updated URL generation to useplacehold.cowith its URL format (/{size}/{bg}/{text}.{format}instead of/{size}.{format}/{bg}/{text})test/faker/default/test_placeholdit.rb: Updated all regex assertions to match the new URL structuredoc/default/placeholdit.md: Updated example output URLsdoc/default/omniauth.md: Updated placeholder image URLs in OmniAuth examplesURL Format Comparison
/{size}.{format}/{size}.{format}/{size}.{format}/{bg}/{size}/{bg}.{format}/{size}.{format}/{bg}/{text}/{size}/{bg}/{text}.{format}...?text=hello...?text=helloTesting
All 19 existing tests pass with updated assertions.