Make title field draggable#5574
Open
ComputelessComputer wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for old-char canceled.
|
Mark the session title shell as a Tauri drag region and let the top-strip drag handler honor explicit drag-region targets while preserving regular input behavior.
1c519fd to
e81872f
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e81872f. Configure here.
| return ( | ||
| <div className="-mx-2 flex h-full flex-col"> | ||
| <div className="relative px-2"> | ||
| <div data-tauri-drag-region className="relative px-2"> |
There was a problem hiding this comment.
Note tabs start window drag
Medium Severity
Marking the whole note header wrapper as a Tauri drag region makes tab and template controls count as explicit drag targets in the main-area pointer handler, so a small pointer move can start window dragging and suppress their click instead of switching tabs or opening the template menu.
Reviewed by Cursor Bugbot for commit e81872f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark the session title shell as a Tauri drag region and let the top-strip drag handler honor explicit drag-region targets while preserving regular input behavior.
Note
Low Risk
Desktop UI and pointer-event behavior only; changes are covered by updated unit tests with no auth or data-path impact.
Overview
Improves frameless window dragging on the desktop app by marking session chrome (title, outer header, note tab header, session surface header) with
data-tauri-drag-region, while keeping real controls clickable viadata-tauri-drag-region="false".The session title shell is draggable when unfocused; on focus it sets the shell to
falseso typing and selection work normally. The main-area pointer handler inbody.tsxnow treatsdata-tauri-drag-region(and optionaldata-main-area-window-drag-region) as explicit drag targets, so dragging can start from those regions even over inputs in the top strip, without stealing drags from ordinary note fields.Reviewed by Cursor Bugbot for commit e81872f. Bugbot is set up for automated code reviews on this repo. Configure here.