Skip to content
This repository was archived by the owner on May 8, 2024. It is now read-only.

Refactoring conditional directives for alternative if statements.#237

Open
wmarquesr wants to merge 2 commits into
fcitx:masterfrom
wmarquesr:master
Open

Refactoring conditional directives for alternative if statements.#237
wmarquesr wants to merge 2 commits into
fcitx:masterfrom
wmarquesr:master

Conversation

@wmarquesr

Copy link
Copy Markdown

A suggestion to compile entire statements and expressions, as suggested by code style guidelines from the Linux Kernel and practitioners.

It might improve code understanding, maintainability and error-proneness.

Comment thread src/frontend/gtk2/fcitximcontext.c Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not declare the variable at the beginning of the function.

@wmarquesr

Copy link
Copy Markdown
Author

All fixed.

@RomeroMalaquias

Copy link
Copy Markdown

Hello, someone can review this pull request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants