fix(ulcl): fix PSA2 selection failure in two-anchor topology#224
Open
lpoclin wants to merge 1 commit into
Open
fix(ulcl): fix PSA2 selection failure in two-anchor topology#224lpoclin wants to merge 1 commit into
lpoclin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a two-anchor ULCL topology, PSA2 is never selected and the ULCL is never established. Three fixes:
SelectPSA2 checked for N3 on the PSA anchor last node. PSA anchors only have N9, so every candidate was skipped. Removed the N3 check.
FindULCL advances psa1CurDPNode without a nil guard. Added nil check to prevent panic when PSA1 is a prefix of PSA2.
bpMGR.ULCL not checked for nil after FindULCL. Added guard before downstream PFCP calls.
Tested on free5GC v4.2.2, Kubernetes, Multus CNI. Related to issue reported on the community forum.