Add COBS encoding/decoding operations#2185
Open
giesmininkas wants to merge 7 commits into
Open
Conversation
Author
|
Hi! Are there any issues with this PR getting merged? Any fixes to make? |
GCHQDeveloper581
requested changes
Apr 9, 2026
GCHQDeveloper581
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good, however at present the "From COBS" operation needs more detection (and handling) of invalid sequences.
(adjust URL prefix to suit your local testing environment)
Author
|
Sorry for that. Updated with additional tests. Should hopefully be good now. |
Author
|
Hi again. Any chance of this getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added COBS encoding/decoding operations.
Requested by #1811.