Open
Conversation
Collaborator
|
Thank you for implementing this, looks awesome! Just a couple of comments:
|
Contributor
Author
Oh right, I see what you mean. So we offer a general validator, independently of whether code-generation is performed or not. That seems like a good idea.
Yeah, seems like a good idea :) at the moment we only know it exercises the codepath because the annotation is removed. I'll check how to do this with scalafix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQLOperation.TypedandGraphQLSubquery.Typedare now pre-processed through the same codegen pipeline as their non-Typedcounterparts and thus fully validated against the schema. However no modifications are applied in this case, since everything is already defined on theTypedsuperclass.