Skip to content

feat(app): improve PR comment display readability in workspace sidebar#1463

Open
TommyLike wants to merge 3 commits into
getpaseo:mainfrom
TommyLike:improve-pr-comment-display
Open

feat(app): improve PR comment display readability in workspace sidebar#1463
TommyLike wants to merge 3 commits into
getpaseo:mainfrom
TommyLike:improve-pr-comment-display

Conversation

@TommyLike

@TommyLike TommyLike commented Jun 11, 2026

Copy link
Copy Markdown

Summary

Improves PR comment/activity display in the workspace sidebar to be more readable.

Problem

The PR pane's activity rows were too compact — comments truncated to 2 lines at 12px in muted color, making it hard to read comment content without clicking through to GitHub.

Changes

  • Increase body truncation: 2 → 4 lines when collapsed, unlimited when expanded
  • Tap-to-expand: Each activity row toggles between collapsed (4 lines) and full text on tap
  • Restructured header: Author on top line, verb + age on second line for better readability
  • Larger body text: fontSize.xs (12px) → fontSize.sm (14px)
  • Smart expand indicator: Chevron icon only appears when text exceeds 4 lines (detected via onTextLayout)
  • External link: Dedicated GitHub link button on each row

Files Modified

  • packages/app/src/git/pr-pane.tsx

Testing

  • ✅ Lint: no errors
  • ✅ Typecheck: no errors in modified file
  • ✅ Format: passed

🤖 Generated with Claude Code

TommyLike and others added 2 commits June 11, 2026 15:09
@TommyLike @claude
feat(app): improve PR comment display readability in workspace sidebar
dc1897c 
- Increase comment body truncation from 2 to 4 lines (collapsed)
- Add tap-to-expand for individual activity rows
- Restructure header layout: author on top, verb/age below
- Increase body text from fontSize.xs to fontSize.sm
- Show chevron indicator when comment text is truncated
- Add external link button for opening comment on GitHub

Co-Authored-By: Claude <noreply@anthropic.com>
@TommyLike
Merge branch 'main' into improve-pr-comment-display
7a35376
@greptile-apps

greptile-apps Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Greptile Summary

This PR improves the readability of PR activity rows in the workspace sidebar: text is enlarged, comments can be expanded in place with a tap, and each row gets a dedicated external-link button.

  • Tap-to-expand: ActivityRow gains local expanded state; numberOfLines toggles between 4 (collapsed) and unlimited (expanded), with a chevron indicator gated on item.body.length > 180.
  • Layout restructure: the old single-Pressable row is split into an outer View (padding/layout), an inner content Pressable (expand toggle), and a sibling Pressable (external link), which avoids the previously nested-Pressable propagation issue.
  • Style updates: body fontSize raised from xs to sm, header restructured to author-on-top + verb·age below.

Confidence Score: 3/5

The change is safe to merge with one functional gap: the chevron expand indicator relies on a character-count estimate that fails for multi-paragraph bodies with explicit newlines, leaving users with no visible affordance to expand truncated text.

The character-count heuristic used to decide whether to show the expand chevron does not account for newline characters in the body. A short body with several line breaks will render as more than 4 lines under numberOfLines=4, but truncated stays false so the chevron never appears. This is a present behavioural defect on the critical expand-toggle path.

packages/app/src/git/pr-pane.tsx — specifically the truncated calculation at line 279 and the interaction between numberOfLines clamping and the character-count heuristic.

Important Files Changed
Filename Overview
packages/app/src/git/pr-pane.tsx Refactored ActivityRow to add tap-to-expand, larger text, and a dedicated external-link button; the character-count heuristic for determining whether to show the expand chevron does not account for explicit newlines, causing the chevron to be hidden on short multi-paragraph bodies.

Reviews (2): Last reviewed commit: "fix(app): address PR review feedback for..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Jun 11, 2026
View reviewed changes
Comment thread packages/app/src/git/pr-pane.tsx Outdated
Comment thread packages/app/src/git/pr-pane.tsx Outdated
Comment thread packages/app/src/git/pr-pane.tsx Outdated
Comment thread packages/app/src/git/pr-pane.tsx Outdated
@TommyLike @claude
fix(app): address PR review feedback for comment display
0fe93da 
- Fix marginLeft:auto pushing ExternalLink off-screen by using
  dedicated activityAge style without auto margin
- Fix nested Pressable event bubbling by moving ExternalLink
  button outside the expand Pressable as a sibling
- Fix Android onTextLayout truncation detection by replacing
  line-count with character-count heuristic (180 chars)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TommyLike