ci(claude-review): cap the review step at timeout-minutes: 10#537
Merged
Conversation
The public Claude Code Review step had no timeout, so a hung run sat in_progress at the job default (360 min) instead of failing fast. A review that stalls is an infra hang, not a slow review (observed on PR #522: a run sat unchanged for 48 min until manually cancelled). Cap the step at 10 minutes so a stalled review resolves to a failed check that can be re-run, matching zep-proprietary's claude-review. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
timeout-minutes: 10to the Run Claude Code Review step in.github/workflows/claude-code-review.yml.Why
The step had no timeout, so the job ran at the GitHub default of 360 minutes. When the action hangs (the Claude step starts, checks out, then stalls with no further output), the check sits
in_progressindefinitely rather than failing.This was observed on PR #522: a review run sat unchanged for 48 minutes (last update 5 s after start) until it was manually cancelled and re-run — the re-run completed cleanly in 9 minutes. A stalled review is an infra hang, not a slow review.
Capping the step at 10 minutes means a hung run fails fast, the check resolves, and
synchronize/reopen (or a manual re-run) re-triggers a fresh review. This matches thetimeout-minutes: 10already used by zep-proprietary'sclaude-code-review.yml.Scope
One line (plus an explanatory comment) on the review step. No behavior change for runs that complete normally — a clean review takes well under 10 minutes.
🤖 Generated with Claude Code