sycl: fix soft_max_f32 max reduction#1534
Open
someoneinjd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the second-stage max reduction in the SYCL softmax kernel when a workgroup contains more subgroups than
WARP_SIZE.Previously, after each subgroup wrote its partial max to
buf_iw[warp_id], the cross-subgroup reduction only loaded:This only reduces the first
WARP_SIZEpartial maxima. For example, on Intel GPUs,WARP_SIZEcan be 16 while the softmax workgroup size is 1024, producing nwarps = 64. In that case, partial maxima frombuf_iw[16..63]were ignored.If the true row max is in one of the ignored subgroups, softmax subtracts a too-small max value. For large attention logits this can overflow
exp(x - max)toinf, eventually producingNaN.llama.cpp PR: ggml-org/llama.cpp#24451