Win32: Clear to black in WM_PAINT for transparent framebuffer windows#2815
Open
jeweg wants to merge 1 commit into
Open
Win32: Clear to black in WM_PAINT for transparent framebuffer windows#2815jeweg wants to merge 1 commit into
jeweg wants to merge 1 commit into
Conversation
The DWM redirection surface may contain undefined alpha values, causing the window to composite incorrectly. PatBlt with BLACKNESS clears both RGB and alpha to zero.
Author
|
For more background, I also explore the approaches for window transparency on Windows in this repository. This particular fix for GLFW uses what I show in |
|
I can confirm this PR fixes the transparency issue I was having on NVIDIA RTX A4000 in DXGI swapchain mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DWM redirection surface may contain undefined alpha values, causing the window to composite incorrectly. PatBlt with BLACKNESS clears both RGB and alpha to zero.
Repro for the issue: https://github.com/jeweg/glfw_repro1