Linux: Fix joystick EV_KEY handling indexing below 0 on keyboard input#2856
Open
tristanbatchler wants to merge 1 commit into
Open
Linux: Fix joystick EV_KEY handling indexing below 0 on keyboard input#2856tristanbatchler wants to merge 1 commit into
tristanbatchler wants to merge 1 commit into
Conversation
Refreshes glfw#2455 by ptrToLiam. Co-authored-by: MediocreDev <liammaloneirlusa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes #2455 by @ptrToLiam, preserving the original code change and contributor credit.
I can reproduce this today with a Keychron Q3 Max connected over Bluetooth via raylib 6.0 / raylib-zig / Zig 0.16.0 on Linux.
Temporary logging in
src/linux_joystick.cshowed:Without this guard, GLFW indexes:
with a negative index and crashes.
I tested #2455’s patch against raylib 6.0's bundled GLFW. The
src/linux_joystick.chunk applied cleanly and fixed my repro; raylib'sInitWindowcompleted and the program exited cleanly.Related: #2484.