Skip to content

Ignore updates for log file when watch is enabled#2015

Merged
joelim-work merged 4 commits into
gokcehan:masterfrom
joelim-work:watch-ignore-log
Jun 20, 2025
Merged

Ignore updates for log file when watch is enabled#2015
joelim-work merged 4 commits into
gokcehan:masterfrom
joelim-work:watch-ignore-log

Conversation

@joelim-work

Copy link
Copy Markdown
Collaborator

Currently it is possible to have an infinite loop with updates to the log file when watch is enabled:

  1. A message is written to the log file
  2. The watch feature detects that the log file has been modified
  3. Something is triggered in response (e.g. on-load hook command, introduced in Add on-load hook #2010, is called)
  4. The above step writes a message to the log file as part of its execution

This can be reproduced using the following minimal config file:

set watch true

# do nothing, just cause an entry to be written to the log file
cmd on-load &true

@joelim-work joelim-work added the fix Pull requests that fix existing behavior label Jun 20, 2025
@joelim-work joelim-work added this to the r36 milestone Jun 20, 2025
@joelim-work joelim-work merged commit 44e716d into gokcehan:master Jun 20, 2025
4 checks passed
@joelim-work joelim-work deleted the watch-ignore-log branch June 20, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Pull requests that fix existing behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant