Skip to content

feat: parallel preview processing #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valoq wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: parallel preview processing #2569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2587e9b
feat: parallel preview processing
valoq May 3, 2026
7bf50d8
fix race
valoq May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions nav.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"os/exec"
"path/filepath"
"regexp"
"runtime"
"slices"
"strconv"
"strings"
Expand Down Expand Up @@ -431,6 +432,12 @@ type clipboard struct {
mode clipboardMode
}

type previewWork struct {
path string
mode string
done chan struct{}
}

type nav struct {
dirPaths []string
copyJobs int
Expand All @@ -452,6 +459,7 @@ type nav struct {
deleteTotalChan chan int
preloadChan chan string
previewChan chan string
workChan chan previewWork
dirChan chan *dir
regChan chan *reg
fileChan chan *file
Expand Down Expand Up @@ -585,6 +593,7 @@ func newNav(ui *ui) *nav {
deleteTotalChan: make(chan int, 1024),
preloadChan: make(chan string, 1024),
previewChan: make(chan string, 1024),
workChan: make(chan previewWork),
dirChan: make(chan *dir),
regChan: make(chan *reg),
fileChan: make(chan *file),
Expand Down Expand Up @@ -731,6 +740,18 @@ func (nav *nav) exportFiles() {
}

func (nav *nav) preloadLoop(ui *ui) {
workers := max(2, runtime.NumCPU()/2)
for range workers {
go func() {
for w := range nav.workChan {
nav.preview(w.path, ui.wins[len(ui.wins)-1], w.mode)
if w.done != nil {
close(w.done)
}
}
}()
}

Comment on lines +743 to +754

@CatsDeservePets CatsDeservePets May 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting gopls:

for loop can be modernized using range over int [default]

stack := []string{}

push := func(path string) {
Expand All @@ -751,9 +772,8 @@ func (nav *nav) preloadLoop(ui *ui) {
select {
case path := <-nav.preloadChan:
push(path)
default:
path := pop()
nav.preview(path, ui.wins[len(ui.wins)-1], "preload")
case nav.workChan <- previewWork{stack[len(stack)-1], "preload", nil}:
pop()
}
}
}
Expand Down Expand Up @@ -799,7 +819,9 @@ func (nav *nav) previewLoop(ui *ui) {
nav.volatilePreview = false
}
if len(path) != 0 {
nav.preview(path, win, "preview")
done := make(chan struct{})
nav.workChan <- previewWork{path, "preview", done}
<-done
prev = path
}
}
Expand Down