fix: copy loop when pasting into copied path#2607
Closed
valoq wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
I would like to support this use case, but:
so for now, I think #2608 is the right, most simple check for the current release and we could revisit this afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting a folder into one of its own subdirectories caused the copy function to loop and recurse.
This skips the destination directory, so the copy is a one-time snapshot of the source.
The alternative as done by coreutils cp would be to fail the attempt to copy inside the yanked path, but this is simpler (and less code) and there may be use cases to allow this.
Note to trigger the issue, paste to a subdirectory not directly into the copied patch because the later often gets lucky and succeeds while pasting into sub dirs reliably crashes the application with error.