Skip to content

Add enumerate() to DSLX stdlib#3816

Open
joannabrozek wants to merge 5 commits intogoogle:mainfrom
antmicro:std-enumarate
Open

Add enumerate() to DSLX stdlib#3816
joannabrozek wants to merge 5 commits intogoogle:mainfrom
antmicro:std-enumarate

Conversation

@joannabrozek
Copy link

This PR adds the 'enumerate()' function with the 'generics' attribute to DSLX stdlib, replacing the existing built-in implementation.

This change was created because we wanted to enable conversion 'enumerate()' to IR.

@joannabrozek joannabrozek changed the title Add enumerate() to DSLX stdlib WIP: Add enumerate() to DSLX stdlib Feb 10, 2026
@joannabrozek joannabrozek changed the title WIP: Add enumerate() to DSLX stdlib Add enumerate() to DSLX stdlib Feb 10, 2026
@joannabrozek joannabrozek marked this pull request as draft February 10, 2026 10:06
@joannabrozek
Copy link
Author

joannabrozek commented Feb 10, 2026

This PR is marked as draft since after adding function with the 'generics' attribute to stdlib, the xls_dslx_fmt_test test started failing, so we're looking into it. We suspect that this test doesn't support GenericTypeAnnotation.

@joannabrozek
Copy link
Author

This PR is marked as draft since after adding function with the 'generics' attribute to stdlib, the xls_dslx_fmt_test test started failing, so we're looking into it. We suspect that this test doesn't support GenericTypeAnnotation.

This issue has now been resolved, so this PR is ready for review.

@joannabrozek joannabrozek marked this pull request as ready for review February 10, 2026 14:19
@tmichalak
Copy link

@richmckeever PTAL

@joannabrozek
Copy link
Author

I rebased on the current main branch and applied suggested changes.
If there's anything else I need to do, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants