fix: resource sharing was generating the wrong visibility edges for one of the folding directions for the general case.#3826
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
…ne of the folding directions for the general case. Also, visibility analysis's GetEdgesForMutuallyExclusiveVisibilityExpr was incorrectly allowing the construction of expressions on a subset of the edges, dropping edges that would cause dependency cycles with other mutually exclusive nodes, without validating whether this results in a valid expression. The function now validates that even with these exclusions, the resulting expression implies that none of the 'others' are visible (and is always true if 'one' is visible) PiperOrigin-RevId: 868357500
7ba0b04 to
eb17569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: resource sharing was generating the wrong visibility edges for one of the folding directions for the general case.
Also, visibility analysis's GetEdgesForMutuallyExclusiveVisibilityExpr was incorrectly allowing the construction of expressions on a subset of the edges, dropping edges that would cause dependency cycles with other mutually exclusive nodes, without validating whether this results in a valid expression. The function now validates that even with these exclusions, the resulting expression implies that none of the 'others' are visible (and is always true if 'one' is visible)