refactor: implement stateful Display and inject io.Writer#84
Open
anj-s wants to merge 1 commit into
Open
Conversation
Closes #64. Adds stateful Display printing for streaming outputs. Removes os.Stdout.Sync() overhead and cleans up dead code. Replaces global stdout redirecting with injected io.Writer dependency, enabling safe parallel unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Displayin the AX CLI client to implement a state machine that tracks the type of last printed chunk (stateNone,stateText,stateThought). This enables real-time concatenation of streamed output blocks (text and reasoning logs) and correctly places separating newlines.io.Writerinterface dependency intoDisplay(defaulting toos.Stdout).bytes.Bufferwrapper.t.Parallel()).os.Stdout.Sync()calls on TTY devices.loadingVisibleandloadingStopCh.Type of Change
Related Issues
Closes #64
Test Plan
go test -v ./cmd/ax/internalpasses.go test ./...passes.