Managed execution frame with async call foundations#1316
Open
TristonianJones wants to merge 3 commits into
Open
Managed execution frame with async call foundations#1316TristonianJones wants to merge 3 commits into
TristonianJones wants to merge 3 commits into
Conversation
l46kok
reviewed
May 15, 2026
l46kok
left a comment
Collaborator
There was a problem hiding this comment.
First pass, I need to re-look at this a couple of more times, but I've mostly focused on the async side of things first
|
|
||
| // AsyncOp is a function that accepts zero or more arguments and produces | ||
| // a value or error asynchronously via a channel. | ||
| type AsyncOp func(context.Context, ...ref.Val) <-chan ref.Val |
Collaborator
There was a problem hiding this comment.
wdyt about explicitly documenting some requirements as an API contract? Something like: implementations must return a buffered channel of capacity at least 1, or ensure background goroutines select on ctx.Done() when sending to prevent leaks when evaluation gets cancelled.
Collaborator
Author
|
@l46kok I've removed all notions of the async call for now and will focus first on the plumbing to introduce |
l46kok
reviewed
Jun 9, 2026
l46kok
left a comment
Collaborator
There was a problem hiding this comment.
LGTM overall, mostly nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of concepts present in the
ExecutionFrame, but it overall introduces the following concepts:ExecutionFrameis a customcontext.Contextvalue whose lifecycle is owned entirely by CELfunctions.AsyncOpandfunctions.BlockingAsyncOpare the signature expected for async call management.The next PRs will introduce the following changes:
Interpretation updates
ExecutionFramevia anInterpretableV2interfaceExecutionFrameExecutionFrameandActivationpoolingAsync calls
Checkpoint evaluation