fix: remove double circle draw in skeletons#1037
Open
seankmartin wants to merge 1 commit into
Open
Conversation
Contributor
|
@seankmartin it looks like the test failure is real |
Contributor
Author
Thanks, I agree it looks real though I'm confused why. My best guess is that something in the test is causing the point to actually go slightly transparent. And the old double rendering meant that two points together made full red and didn't let the background through. I'll try changing the background to see. Edit - changing the background changes the result, so pretty sure that's what is going on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skeletons were double rendering points due to calling
drawCircleswith two points per instance. This had generally little impact practically unless skeletons were rendered transparent. In that case the nodes double rendering would make them less transparent than the lines. This did kind of hide a bit that the lines were still rendering under points, but if we want to keep that visual effect we should do it explicitly instead of a double render.Example in neuroglancer.demo
Master branch version:
This PR version:
