Skip to content

Make out-of-range values visible at the bottom of the plot#1299

Draft
argilo wants to merge 1 commit into
masterfrom
fix-clamping
Draft

Make out-of-range values visible at the bottom of the plot#1299
argilo wants to merge 1 commit into
masterfrom
fix-clamping

Conversation

@argilo

@argilo argilo commented Oct 3, 2023

Copy link
Copy Markdown
Member

This is an alternative to #1296.

Instead of removing clamping, we could correct the clamping calculation so that out-of-range values are visible at the lower edge of the plot the same way as they are at the top.

Before:
Screenshot from 2023-10-03 09-31-20

After:
Screenshot from 2023-10-03 09-30-05

@willcode

willcode commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

This had no effect for me, but replacing 1.0f with 2.0f did work. There may be some combination of m_DPR and rounding affecting this. I did not find the magic constant in a few tries.

@argilo

argilo commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

Oops, I guess I'll have to do a deeper dive into the calculations to see what's going on.

@argilo argilo marked this pull request as draft October 3, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants