Skip to content

Release v1.6.0 Fixes#4059

Open
VishalDalwadi wants to merge 1 commit into
developfrom
fixes/release-v1.6.0
Open

Release v1.6.0 Fixes#4059
VishalDalwadi wants to merge 1 commit into
developfrom
fixes/release-v1.6.0

Conversation

@VishalDalwadi

Copy link
Copy Markdown
Collaborator

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@tenki-reviewer

tenki-reviewer Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Complete
No issues found!

Risk: 🟡 Medium (38/100) — no findings · 1 LOC across 1 file


This PR adds removal of a deleted node from nameserver Nodes maps during cleanup, but the existing update/delete condition only checks len(ns.Servers) > 0, which can cause nameserver records that still have other node references to be silently deleted.

Files Reviewed (1 files)
logic/nodes.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant