Skip to content

Fix/translations/consistent zmanim caps#22

Merged
mjradwin merged 3 commits into
hebcal:mainfrom
chaimleib:fix/translations/consistent-zmanim-caps
Feb 20, 2026
Merged

Fix/translations/consistent zmanim caps#22
mjradwin merged 3 commits into
hebcal:mainfrom
chaimleib:fix/translations/consistent-zmanim-caps

Conversation

@chaimleib

@chaimleib chaimleib commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Split from #20.

Make capitalization consistent for "Chatzot hayom" -> "Chatzot HaYom", "Alot haShachar"->"Alot HaShachar". This aligns with "Bein HaShemashot" and "Tzeit HaKochavim".

@chaimleib chaimleib force-pushed the fix/translations/consistent-zmanim-caps branch from 1e21c84 to 9aec020 Compare February 18, 2026 18:02
@chaimleib chaimleib marked this pull request as draft February 18, 2026 18:12
@chaimleib

Copy link
Copy Markdown
Contributor Author

Whoops! I forgot to push updates to hebcal-es6. Drafting until that is fixed.

@chaimleib

Copy link
Copy Markdown
Contributor Author

I created a PR for adding missing po strings to @hebcal//core: hebcal/hebcal-es6#702

@sonarqubecloud

Copy link
Copy Markdown

@chaimleib chaimleib marked this pull request as ready for review February 19, 2026 05:22
@mjradwin mjradwin merged commit 4be185c into hebcal:main Feb 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants