fix(hebcal): skip non-existent year 0 when computing Gregorian end date#23
Merged
Conversation
When a user requested a calendar starting in a BC year (e.g. year=-1) with the default NumYears=1, getStartAndEnd computed the end as greg.ToRD(year+numYears, January, 1) = greg.ToRD(0, ...), which panics because the historical Gregorian calendar has no year 0 (1 BC is immediately followed by 1 AD). Bump the end year past 0 whenever the range crosses the BC/AD boundary so that the requested number of years of output is preserved. Reported in hebcal/hebcal#310.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user requested a calendar starting in a BC year (e.g. year=-1) with
the default NumYears=1, getStartAndEnd computed the end as
greg.ToRD(year+numYears, January, 1) = greg.ToRD(0, ...), which panics
because the historical Gregorian calendar has no year 0 (1 BC is
immediately followed by 1 AD). Bump the end year past 0 whenever the
range crosses the BC/AD boundary so that the requested number of years
of output is preserved.
Reported in hebcal/hebcal#310.