Add translation of exceptions in met #155765
Draft
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Met.no integration to use translatable exceptions following Home Assistant's Gold tier quality scale requirements. The changes replace a custom exception class with Home Assistant's built-in exception classes that support translation keys.
- Removed custom
CannotConnectexception class in favor ofHomeAssistantErrorwith translation support - Added exception translations to
strings.jsonfor user-facing error messages - Updated exception handling to use translation keys and placeholders
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/met/strings.json | Adds "exceptions" section with translation keys for cannot_connect and update_failed error messages |
| homeassistant/components/met/coordinator.py | Removes custom CannotConnect exception class and updates exception raising to use HomeAssistantError and UpdateFailed with translation support |
joostlek
requested changes
Nov 4, 2025
| """Fetch data from Met.""" | ||
| try: | ||
| return await self.weather.fetch_data() | ||
| except Exception as err: |
There was a problem hiding this comment.
Okay so 2 things
- Ideally we don't catch raw Exceptions outside of the config flow and outside of tasks, so IMO we should just remove this except. This might uncover some bugs like a ValueError or AttributeError, but we should watch for those and properly fix the code
- You're now raising a translated exception to be caught and to be raised again as translated exception, I think we can just do this once
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Ref: https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/exception-translations
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: