Skip to content

Conversation

@gjohansson-ST
Copy link
Member

Breaking change

Proposed change

Improves code formatting and sorting in System monitor.
Prel PR for #151066

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR alphabetically organizes various data structures, constants, and entity descriptions in the systemmonitor component to improve code maintainability and readability.

Key changes:

  • Alphabetizes tuple elements and dictionary keys throughout the codebase
  • Reorders entity descriptions in the SENSOR_TYPES dictionary
  • Reformats multi-line lambda expressions to follow style guidelines

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/systemmonitor/sensor.py Alphabetizes constants (SENSORS_NO_ARG, SENSORS_WITH_ARG, IO_COUNTER, IF_ADDRS_FAMILY), reorders sensor entity descriptions, and improves lambda formatting
homeassistant/components/systemmonitor/coordinator.py Alphabetizes SensorData dataclass fields, as_dict() return dictionary, set_subscribers_tuples() dictionary, SensorData instantiation parameters, and update_data() return dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants