-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
Map Z-Wave Jasco model 14314 fan speed to low/medium/high #155817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Z-Wave fan switch Jasco 14314 supports only 3 speeds, low (1-33%), medium (34-66%), and high (67-99%). Prior to this change, any percentage could be selected in the UI, but the resulting fan speed would be determined by the listed low/medium/high ranges. This change aligns fan 14314 behavior with other functionally identical fan switches (e.g. 14287).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @strikeir13
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! We need to add tests of this. I left the same comment in the other open PR that changes this.
Breaking change
This changes how the UI displays fan speeds for this model, showing low/med/high as options rather than 0-100%, but it does not change the actual fan speed that was selected.
Old:


New:
Proposed change
Z-Wave fan switch Jasco 14314 supports only 3 speeds, low (1-33%), medium (34-66%), and high (67-99%). Prior to this change, any percentage could be selected in the UI, but the resulting fan speed would be determined by the listed low/medium/high ranges. This change aligns fan 14314 behavior with other functionally identical fan switches (e.g. 14287). Model 14287 had the same change made back in 2021: #60517.
I have tested this change on my own instance and it works as described above, so I've checked that box below. Since I am not a developer, however, I'm leaving the other checklist boxes unchecked. I'm hoping this is a minor enough change that much of the checklist is not applicable.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: