refactor(image): inline user PATH setup into fleet wrapper script#1040
Open
anna (anna328p) wants to merge 1 commit into
Open
refactor(image): inline user PATH setup into fleet wrapper script#1040anna (anna328p) wants to merge 1 commit into
anna (anna328p) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors lib/image/fleet.nix for style clarity and keeps ix-fleet PATH setup colocated with the command wrapper.
Changes:
- Simplified attribute set
inheritformatting (inherit name;). - Inlined the Nushell
$env.PATHaugmentation logic directly intomkFleetCmd’s wrappedmain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
85c0556 to
5561cb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline the
userLocalBinPathhelper into the fleet wrapper's Nushell body and move its comment next to the code it describes. The helper was only used once, and the indirection made the generated script harder to read at the definition site. No behavior change.🤖 Generated with Claude Code
Note
Inline PATH setup into fleet wrapper script in
lib/image/fleet.nixRemoves the
userLocalBinPathlet-binding and inlines the Nushell block that conditionally prepends$HOME/.local/binto PATH directly intomkFleetCmd. This is a pure refactor with no functional change.Macroscope summarized 5561cb2.