-
-
Notifications
You must be signed in to change notification settings - Fork 171
Add support for Symfony 8 #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
.github/workflows/tests.yaml
Outdated
| coverage-driver: xdebug | ||
| symfony-version: '6.4.*' | ||
| - operating-system: ubuntu-latest | ||
| php-version: '8.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we would like to test against 8.5 too. I'd suggest to add symfony 8 in the symfony-version and add to exclude testing against php < 8.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, that's a better alternative.
However, I had to modify the composer config minimum-stability dev step to run when we try to install a dev version of Symfony. Maybe I missed something with the matrix configuration, but it's not possible to only configure the old matrix.minimum-stability config only when using Symfony 8.0.x-dev, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, directly with the matrix, like I was able to do with include from the 1st commit.
It should be fine now, I see that some Symfony 8 packages are installed in https://github.com/infection/infection/actions/runs/19081901778/job/54512486280?pr=2551, but there is still PHPBench that force Symfony 7.x for symfony/console or symfony/filesystem for example.
|
Comments addressed, thanks! |
This PR increase version constraints on
symfony/*packages to allow Symfony 8, which will be released this month.EDIT: opened phpbench/phpbench#1125