Skip to content

Conversation

@Kocal
Copy link

@Kocal Kocal commented Nov 4, 2025

This PR increase version constraints on symfony/* packages to allow Symfony 8, which will be released this month.

EDIT: opened phpbench/phpbench#1125

coverage-driver: xdebug
symfony-version: '6.4.*'
- operating-system: ubuntu-latest
php-version: '8.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would like to test against 8.5 too. I'd suggest to add symfony 8 in the symfony-version and add to exclude testing against php < 8.4

Copy link
Author

@Kocal Kocal Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, that's a better alternative.

However, I had to modify the composer config minimum-stability dev step to run when we try to install a dev version of Symfony. Maybe I missed something with the matrix configuration, but it's not possible to only configure the old matrix.minimum-stability config only when using Symfony 8.0.x-dev, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kocal it is possible. GA supports if condition.

As an example you could take a look at the PR #1892 and what we did there in order to introduce Symfony 7.0 support

Copy link
Author

@Kocal Kocal Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, directly with the matrix, like I was able to do with include from the 1st commit.

It should be fine now, I see that some Symfony 8 packages are installed in https://github.com/infection/infection/actions/runs/19081901778/job/54512486280?pr=2551, but there is still PHPBench that force Symfony 7.x for symfony/console or symfony/filesystem for example.

@Kocal
Copy link
Author

Kocal commented Nov 4, 2025

Comments addressed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants