perf: enable Turbopack filesystem cache for agents-docs builds#2048
perf: enable Turbopack filesystem cache for agents-docs builds#2048nick-inkeep merged 2 commits intomainfrom
Conversation
Enable turbopackFileSystemCacheForBuild in agents-docs and persist .next/cache in CI via a dedicated GHA cache step. This targets the largest CI bottleneck (agents-docs cold build: 3.7-6.3min, 40-56% of CI time) with the same incremental caching approach used for agents-manage-ui in #2045. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
💭 Consider (1) 💭
Inline Comments:
- 💭 Consider:
.github/workflows/ci.yml:72Cache key differs from agents-manage-ui pattern (omitspackages/agents-core/src/**)
✅ APPROVE
Summary: Clean, low-risk infrastructure optimization that follows the established pattern from PR #2045. The Turbopack cache flag and GHA cache step are correctly implemented. The only observation is a minor inconsistency in cache key composition vs. the agents-manage-ui pattern — but this doesn't affect correctness, just cache invalidation behavior. Ship it! 🚀
Discarded (3)
| Location | Issue | Reason Discarded |
|---|---|---|
.github/workflows/ci.yml:69 |
Action pinned to mutable tag v4 instead of SHA |
Pre-existing pattern across all actions in this workflow; not introduced by this PR |
agents-docs/next.config.ts |
Experimental flag correctly mirrors pattern | Informational note confirming correctness; no issue identified |
| Cypress workflow | Does not include agents-docs cache | Acceptable — Cypress only tests agents-manage-ui, so no agents-docs cache is needed |
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
4 | 0 | 0 | 0 | 1 | 0 | 3 |
| Total | 4 | 0 | 0 | 0 | 1 | 0 | 3 |
|
Re: cache key consistency — accepted. Added |
Add packages/agents-core/src/** to agents-docs cache key source hash for consistency with agents-manage-ui pattern, since agents-docs imports from agents-core. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |
Summary
turbopackFileSystemCacheForBuild: trueinagents-docs/next.config.tsactions/cachestep in CI workflow to persistagents-docs/.next/cachenextjs-docs-build) from agents-manage-ui to avoid interferenceMotivation
agents-docs cold build is the single largest CI bottleneck: 3.7-6.3 minutes, consuming 40-56% of total CI time. This applies the same Turbopack incremental caching approach shipped for agents-manage-ui in #2045.
Cache key design
lockfile-hash: Invalidates when Next.js version changessource-hash: Coversagents-docs/content/**andagents-docs/src/**Expected impact
Based on agents-manage-ui results (~45% speedup with warm cache), expecting agents-docs build to drop from ~6min cold to ~3min warm on subsequent runs.
Test plan
agents-docs/.next/cache🤖 Generated with Claude Code