[Driver][SYCL] Do not claim RDC flag for option enabling#22237
Open
mdtoguchi wants to merge 6 commits into
Open
[Driver][SYCL] Do not claim RDC flag for option enabling#22237mdtoguchi wants to merge 6 commits into
mdtoguchi wants to merge 6 commits into
Conversation
In the driver, any touch of an option with hasFlag, or hasArg, etc will claim that the option has been used. In the new offloading model, -fno-sycl-rdc is not yet implemented, so any actual use of the option is not representative of true usage. Do not mark use of -fno-gpu-rdc (-fno-sycl-rdc is an alias) when being used to add an option to the `-cc1` step. This allows for the driver ti properly recognize that -fno-sycl-rdc is not being used when the new model is enabled. This change allows for any true -fno-sycl-rdc testing to emit a diagnostic when used with the new offload model. We can then error on this diagnostic to show failure with the new model for improved visibility and tracking of functionality.
Contributor
Author
|
Failures seen are from performing testing with the new offloading model enabled. The AOT/early_aot.cpp fails are expected and what we want to see. AOT/early_aot.cpp exercises the use of |
Contributor
|
It looks like |
Contributor
|
nit: typo: driver ti properly -> driver to properly |
YuriPlyakhin
approved these changes
Jun 11, 2026
YuriPlyakhin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, assuming CI is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the driver, any touch of an option with hasFlag, or hasArg, etc will claim that the option has been used. In the new offloading model, -fno-sycl-rdc is not yet implemented, so any actual use of the option is not representative of true usage.
Do not mark use of -fno-gpu-rdc (-fno-sycl-rdc is an alias) when being used to add an option to the
-cc1step. This allows for the driver to properly recognize that -fno-sycl-rdc is not being used when the new model is enabled.This change allows for any true -fno-sycl-rdc testing to emit a diagnostic when used with the new offload model. We can then error on this diagnostic to show failure with the new model for improved visibility and tracking of functionality.
The update to sycl/test-e2e/SYCLBIN/link_object_fast_link.cpp is to prevent test failure due to usage of
-fsycl-rdc. The use of this option is not doing anything, as-fsycl-rdcis the default mode. Builds are performed with-Werrorcausing the unused argument warning to become an error.