add escape_unfocuses field to PyCUI#145
Open
tadeaspaule wants to merge 2 commits into
Open
Conversation
Owner
|
I've thought about this, and would it perhaps be better to have the unfocus key be settable? With |
Author
|
Agreed
…-------- Original Message --------
On 29 Dec 2021, 21:09, Jakub Wlodek wrote:
I've thought about this, and would it perhaps be better to have the unfocus key be settable? With KEY_ESCAPE just the default? We could even add the option to set it to None so that there is no default unfocus key
—
Reply to this email directly, [view it on GitHub](#145 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AH5QQLCSYGVGG3YDNQOZ6SDUTNTF5ANCNFSM5D6Q5V4Q).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More control over Escape / focus behavior. For use cases like single-widget applications and those that never want to go out of focus mode
What this pull request changes
escape_unfocusesfield to PyCUI objects, defaultTrue. If set toFalse, user can provide widget-specific behavior for when Esc is pressed.Issues fixed with this pull request
escape_unfocuses == Falseyou can dowidget.add_key_command(py_cui.keys.KEY_ESCAPE, foo))