give expressions reified types#1379
Merged
otaviojava merged 5 commits intojakartaee:mainfrom Feb 20, 2026
Merged
Conversation
gavinking
commented
Feb 17, 2026
api/src/main/java/jakarta/data/spi/expression/literal/ComparableLiteralRecord.java
Outdated
Show resolved
Hide resolved
Member
Author
I have solved this, but at the cost of making it hard to construct literal instances of unrecognized types. |
10a2a59 to
e675d5c
Compare
Member
Author
|
This latest revision is a lot more convincing. |
njr-11
approved these changes
Feb 18, 2026
Member
njr-11
left a comment
There was a problem hiding this comment.
This looks good. I suggested a few very minor updates.
api/src/main/java/jakarta/data/spi/expression/literal/ComparableLiteral.java
Outdated
Show resolved
Hide resolved
gavinking
commented
Feb 18, 2026
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1290
This does not work out very well for literal values, where I need unchecked/unsound casts.