Enter worktree with spaces#115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
port enterand the implicitport <branch>form, in all forms:port enter "my feature",port enter my feature,port "my feature", andport my feature.joinBranchArgshelper insrc/index.ts).my feature→ branchmy-feature), while valid refs likefeature/authare preserved (newisValidBranchRef/resolveBranchRefinsrc/lib/git.ts, used byenter.ts). Worktree directory naming andPORT_WORKTREEidentity stay sanitized and unchanged.execPortAsyncnow usesexecFile(no shell) so spaced args and script paths survive (tests/utils.ts,src/lib/exec.ts).docs/superpowers/specs/.Testing
joinBranchArgsunit tests (src/index.test.ts);isValidBranchRef/resolveBranchRefunit tests (src/lib/git.test.ts); command-level spaced-branch case (src/commands/enter.command.test.ts); smoke E2E covering explicit and implicit forms (tests/enter-spaces.test.ts).typecheckclean;lint0 errors (only pre-existing unrelated warnings);prettierclean.Risks
enter/ implicit entry points and the test harness, with no change to worktree directory or domain/routing identity.(Drafted by Jacob's coding agent on his behalf)