keep_files option now supports globs#9947
Conversation
|
@mattr- @ashmaroli Hello! Sorry for ping, guys, but would you mind reviewing this? I would not like this to become a stale PR for months .. |
|
The CI builds need investigation/fixing. The spell check build failures can be ignored. |
Seems like this error also exist in |
|
Yea, well, seems like minitest 6.x handles plugins in some new way, so they should be registered manually. I reverted back the They're still failing, probably something else got broken since last green build. I'll check this in a few hours. |
51842de to
f21efa9
Compare
|
@mattr- should be good now.
|
|
Well, it was challenging to debug, but flaky |
|
@mattr- Sorry for another ping, but would you mind reviewing this one more time? |
|
@mattr- Friendly reminder =) |
|
@seroperson This is in my review queue and when I'm ready, I'll give it another look. Working to knock some other stuff out first. |
This is a 🙋 feature or enhancement.
Summary
keep_filesoption now supports globs to get in line withincludeandexclude.Context
Closes #9804