Skip to content

keep_files option now supports globs#9947

Open
seroperson wants to merge 4 commits into
jekyll:masterfrom
seroperson:i9804-keep-files-glob
Open

keep_files option now supports globs#9947
seroperson wants to merge 4 commits into
jekyll:masterfrom
seroperson:i9804-keep-files-glob

Conversation

@seroperson

Copy link
Copy Markdown

This is a 🙋 feature or enhancement.

Summary

keep_files option now supports globs to get in line with include and exclude.

Context

Closes #9804

@seroperson

Copy link
Copy Markdown
Author

@mattr- @ashmaroli Hello! Sorry for ping, guys, but would you mind reviewing this? I would not like this to become a stale PR for months ..

@mattr-

mattr- commented Mar 10, 2026

Copy link
Copy Markdown
Member

The CI builds need investigation/fixing. The spell check build failures can be ignored.

@seroperson

Copy link
Copy Markdown
Author

The CI builds need investigation/fixing. The spell check build failures can be ignored.

Seems like this error also exist in master. Yea, I'll fix it here then, and rebase my other PR after this got merged.

@seroperson

Copy link
Copy Markdown
Author

Yea, well, seems like minitest 6.x handles plugins in some new way, so they should be registered manually. I reverted back the --profile option and manually register this plugin if such API is available.

They're still failing, probably something else got broken since last green build. I'll check this in a few hours.

@seroperson seroperson force-pushed the i9804-keep-files-glob branch from 51842de to f21efa9 Compare March 10, 2026 22:15
@seroperson

seroperson commented Mar 10, 2026

Copy link
Copy Markdown
Author

@mattr- should be good now.

  • --profile now works for both ruby 2.x and 3.x.
  • export TZ=UTC instead TZ=UTC because old variant doesn't propagate into child processes.
  • Use assert_nil if comparing with nil, for some reason using assert_equal with nil doesn't work in ruby 3.x.
  • Manually excluded test_coffeescript.rb test, as jekyll-coffeescript produces a little bit different output under ruby 3.x. This plugin is 5+ years old and probably should be updated. At the end feels like this test fits better in the jekyll-coffeescript's repo.
  • Added spelling exclusion.

@seroperson

Copy link
Copy Markdown
Author

Well, it was challenging to debug, but flaky test_site.rb:81 didn't see a cache dir because @disk_cache_enabled in cache.rb sometimes stuck in false state. Whether it fail or not depends on test execution order.

@seroperson

Copy link
Copy Markdown
Author

@mattr- Sorry for another ping, but would you mind reviewing this one more time?

@seroperson

Copy link
Copy Markdown
Author

@mattr- Friendly reminder =)

@mattr-

mattr- commented Mar 30, 2026

Copy link
Copy Markdown
Member

@seroperson This is in my review queue and when I'm ready, I'll give it another look. Working to knock some other stuff out first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add support for globs in the keep_files option

2 participants