Add env var coverage to wrapper tests#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PYWRAP_PIP_ARGSandPYWRAP_LOCK_POLL_SEC.Description
_run_wrapperand_venv_dirand importedjsontotests/test_wrapper.pyto simplify invoking the wrapper and inspecting the venv.PYWRAP_REQUIREMENTS, cache-mode directory viaPYWRAP_CACHE_DIR, force recreation viaPYWRAP_FORCE_RECREATE, and pip args handling viaPYWRAP_PIP_ARGS.PYWRAP_LOCK_POLL_SECfor faster polling during the timeout scenario.Testing
python -m unittest tests.test_wrapperwhich executed the test suite.OK, 8 tests run).Codex Task