Document and test local-first pip installs#9
Closed
jianliang00 wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PYWRAP_LOCAL_FIRST.local_firstflag is recorded in the.venv/.pywrap/ok.jsonmarker.Description
PYWRAP_LOCAL_FIRSTenvironment variable inREADME.mdand its behavior when set to1.python3) to accept alocal_firstflag fromPYWRAP_LOCAL_FIRST, added a_pip_installhelper that performspip downloadinto a temporary directory thenpip install --no-index --find-linkswhen enabled, and ensured the temp download directory is cleaned up.local_firstboolean into the venv marker written by_write_markerso the metadata includes the install mode.test_local_first_records_marker_flagintests/test_wrapper.pyto validate the marker containslocal_first.Testing
python -m unittest tests/test_wrapper.pyand it completed successfully.Ran 9 testsand exitedOK.Codex Task