Reinstall deps when local-first or pip args change#10
Merged
jianliang00 merged 1 commit intoJan 7, 2026
Merged
Conversation
09d1275 to
1971db4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PYWRAP_PIP_ARGSorPYWRAP_LOCAL_FIRSTtrigger dependency reinstalls by including them in the venv marker check.Description
pip_argsandlocal_firstin the marker validation so marker mismatches will trigger reinstall when these settings change._install_depsto accept alocal_firstflag and implement a_pip_installhelper that usespip downloadinto a temporary directory and thenpip install --no-index --find-linkswhenlocal_firstis enabled, with cleanup of the temp dir.pip_argsandlocal_firstinto the.venv/.pywrap/ok.jsonmarker when creating/updating the marker.PYWRAP_LOCAL_FIRSTinREADME.mdand add the unit testtest_local_first_records_marker_flagintests/test_wrapper.py.Testing
python -m unittest tests/test_wrapper.py.Ran 9 testsand exitedOK.test_local_first_records_marker_flagpassed as part of the suite.Codex Task