Add variables property to template frontmatter#76
Open
ezhikov wants to merge 1 commit into
Open
Conversation
epszaw
suggested changes
Nov 28, 2018
epszaw
left a comment
There was a problem hiding this comment.
I think there are must be some tests for that functionality 🤔
Owner
|
@ezhikov any possibility to add tests? LMK if you need help with understanding how testing works here |
Author
|
I think I do need guidance with tests. |
|
@ezhikov it's very simple. Look at other test a try to do the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
So, my proposed solution to #61 is to add property
variablesto frontmatter. Other arguments have priority over variables. One thing that I'm uncertain with, if variables should be calculated depending on other variables.If my solution satisfies you, I'll add relative section to docs and tests if you'llguide me on how to properly test this feature.