Skip to content

fix: publicApiUrl deployment configuration and optimize auth provider tests#539

Open
5rk7n wants to merge 5 commits into
jonwiggins:mainfrom
5rk7n:main
Open

fix: publicApiUrl deployment configuration and optimize auth provider tests#539
5rk7n wants to merge 5 commits into
jonwiggins:mainfrom
5rk7n:main

Conversation

@5rk7n

@5rk7n 5rk7n commented May 30, 2026

Copy link
Copy Markdown

Summary

This fix addresses an issue where the PUBLIC_API_URL service was missing its default process or environment variable configuration during deployment. It ensures that the publicApiUrl is properly configured, utilized across the API, and thoroughly covered by unit and integration tests.

Changes

  • Fixed the missing publicApiUrl deployment variable to ensure the service initializes correctly.
  • Updated the API to correctly utilize the publicApiUrl variable.
  • Testing & Quality Assurance:
    • Added dedicated unit tests for provider auth: getCallbackUrl.
    • Added test case specifically to github google oidc targeting getCallbackUrl.
    • Optimized multiple provider tests using describe.each for better maintainability and cleaner execution.

Testing

  • Tests pass (pnpm turbo test)
  • Typechecks pass (pnpm turbo typecheck)
  • Helm pass (helm lint)

Related

Closes #

Screenshots

@5rk7n 5rk7n changed the title fix: public-apiurl deployment configuration and optimize auth provider tests fix: publicApiUrl deployment configuration and optimize auth provider tests May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant