Support remote file configuration#25
Open
kylef wants to merge 1 commit into
Open
Conversation
kattrali
reviewed
Sep 3, 2018
kattrali
left a comment
Collaborator
There was a problem hiding this comment.
Can the printed response be tested somehow?
|
|
||
| response = requests.get(url) | ||
| response.raise_for_status() | ||
| print(response.text) |
Collaborator
There was a problem hiding this comment.
Should this always print or only if there’s a problem?
b4db86a to
af36ab6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for remotely referencing a configuration file. The justification is found in the documentation inside
docs/config.rst, I recommend you read that part of the changeset first.This is MVP for the feature, it could be improved upon in the future. Right now only references at root, and only one level deep is supported.