fix: MCP server CWD and config loading (v0.5.5)#59
Merged
Conversation
Addresses P1 review from Codex: MCP server must change working directory to OSIRIS_HOME before loading configuration. Problem: - MCP clients (Claude Desktop) launch server from their own CWD - Config loaders search for osiris.yaml relative to Path.cwd() - Server ran with defaults, missing project config and connections Solution: - Added os.chdir(osiris_home) in setup_environment() - Ensures all relative path lookups work correctly - Config files (osiris.yaml, osiris_connections.yaml) now found Verified: - Server started from /tmp with --base-path /project - Config successfully loaded from project directory - Selftest passes with correct config values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration details now shown only with --verbose or -v flag. Default output: - Clean JSON snippet - Helpful tip about multiple servers - No debugging information With --verbose: - Shows installation type, config source, paths - Useful for troubleshooting configuration issues Example: osiris mcp clients # Clean output osiris mcp clients -v # With details osiris mcp clients --verbose # With details 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes critical P1 issue identified by Codex: MCP server must change working directory to OSIRIS_HOME to properly load project configuration.
Problem (Codex P1 Review)
Root cause:
~/Library/Application Support/Claude)osiris.yamlrelative toPath.cwd()Solution
Added
os.chdir(osiris_home)insetup_environment()after resolving OSIRIS_HOME:Verification
Tested server startup from different CWD:
Results:
Config successfully loaded despite running from different directory! ✅
All Changes in This PR
--base-pathparameterosiris.yamlfor pip installsTesting
/tmpwith--base-path /projectVersion
v0.5.5
🤖 Generated with Claude Code