fix: Correct capabilities format in component developer skill#62
Merged
Conversation
Fix critical issue where skill taught incorrect capabilities format: **What was wrong:** - Skill taught capabilities as array: `capabilities: [- discover, - healthcheck]` - Referenced non-existent "healthcheck" capability - Would cause validation failures when following skill instructions **What's correct (per spec.schema.json):** - Capabilities MUST be object with boolean flags - 8 standard capabilities: discover, adHocAnalytics, inMemoryMove, streaming, bulkOperations, transactions, partitioning, customTransforms - No "healthcheck" or "doctor" capability exists (doctor is a driver method, not capability) **Changes:** - SKILL.md: Fixed spec.yaml template with correct capabilities object - SKILL.md: Updated frontmatter description - SKILL.md: Fixed docstrings (discover, doctor) - CHECKLIST.md: Updated CAP-001 to CAP-004 rules - POSTHOG_EXAMPLE.md: Fixed capabilities to use object format - TEMPLATES.md: Fixed minimal spec.yaml template **Validated:** - Checked all actual component specs (mysql, supabase, etc.) - Confirmed against components/spec.schema.json - Reference docs already correct Discovered by Codex CLI review. Thanks to OpenAI model for catching this! 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (Critical Bug)
The osiris-component-developer skill was teaching incorrect capabilities format that would cause validation failures.
What Was Wrong ❌
Issues:
"healthcheck"capabilityWhat's Correct ✅
According to
components/spec.schema.json:8 standard capabilities (per spec.schema.json):
discover,adHocAnalytics,inMemoryMove,streamingbulkOperations,transactions,partitioning,customTransformsNote: No
"healthcheck"or"doctor"capability exists.doctor()is a driver method, not a capability.Changes
Fixed in 4 files:
SKILL.md:
discover()anddoctor()methodsCHECKLIST.md:
truecapabilities need implementationPOSTHOG_EXAMPLE.md:
TEMPLATES.md:
Validation
✅ Checked against actual component specs:
components/mysql.extractor/spec.yamlcomponents/supabase.extractor/spec.yamlcomponents/filesystem.csv_extractor/spec.yaml✅ Confirmed against
components/spec.schema.json✅ Reference docs (
docs/reference/COMPONENT_CAPABILITIES_*.md) already correctCredit
Issue discovered by Codex CLI review. Thanks to OpenAI model for catching this critical bug! 🙏
Impact
🤖 Generated with Claude Code