GH actions for ci.yaml workflow - testsuite deprecation check.#46351
Open
lhanusov wants to merge 1 commit intokeycloak:mainfrom
Open
GH actions for ci.yaml workflow - testsuite deprecation check.#46351lhanusov wants to merge 1 commit intokeycloak:mainfrom
lhanusov wants to merge 1 commit intokeycloak:mainfrom
Conversation
a50d843 to
51a2326
Compare
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
51a2326 to
ae4f4a1
Compare
stianst
reviewed
Feb 16, 2026
Contributor
stianst
left a comment
There was a problem hiding this comment.
We should add testsuite/DEPRECATED.md in the same PR; and it would probably be better to link to that file than the new test framework docs, as it can explain that it's deprecated, why, and also link to the new test framework docs and new base tests module.
stianst
reviewed
Feb 16, 2026
| echo "Checking testsuite module changes." | ||
| echo "----------------------------------------------------------------------------------------" | ||
|
|
||
| CHANGED_FILES=$(gh api -X GET --paginate repos/$REPOSITORY/pulls/$CHANGE_ID/files --jq 'map(select(.filename | contains("testsuite/")) | select (.changes >= 50) | {filename}) | length') |
Contributor
There was a problem hiding this comment.
Very nice and clean approach. Have you tried it out to verify this does what we want? Will it also include new files and not just updated files?
Contributor
There was a problem hiding this comment.
We should differentiate between new files (not allowed) and updates to existing files (only X lines allowed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46291