Open
Conversation
d269de4 to
1b77981
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
1b77981 to
b9da670
Compare
Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
Not necessary anymore Signed-off-by: twobiers <22715034+twobiers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, this PR adds docker support to running playwright tests.
It detects whether either podman or docker are available on the system and patches the default config with the necessary commands. It's also making use of
podman info/docker infoto ensure the container engine can be used.Tested on my machine, as I'm using docker.