Skip to content

Rc 1010#1012

Merged
garronej merged 4 commits into
mainfrom
rc_1010
Mar 21, 2026
Merged

Rc 1010#1012
garronej merged 4 commits into
mainfrom
rc_1010

Conversation

@garronej
Copy link
Copy Markdown
Collaborator

@garronej garronej commented Mar 21, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores

    • Version updated to 11.15.2-rc.1 release candidate

  • Bug Fixes

    • Fixed asset path handling to correctly process multiple quote styles in generated code, improving compatibility with various build tool outputs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 21, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f33897c-4c7e-4683-8834-b610263816c7

📥 Commits

Reviewing files that changed from the base of the PR and between 00debb8 and f68d417.

📒 Files selected for processing (3)
  • package.json
  • src/bin/keycloakify/replacers/replaceImportsInJsCode/vite.ts
  • test/bin/replacers.spec.ts
📝 Walkthrough

Walkthrough

Package version bumped to a release candidate. Vite asset-path replacer expanded to handle single-quoted, double-quoted, and template-literal string forms. Four new test cases validate replacement behavior across quote styles and path configurations on POSIX and Windows systems.

Changes

Cohort / File(s) Summary
Version Update
package.json		 Version incremented from 11.15.1 to 11.15.2-rc.1.
Vite Asset Path Replacement Logic
src/bin/keycloakify/replacers/replaceImportsInJsCode/vite.ts		 Import statements reorganized. Core replacement logic expanded to process asset paths across all three quote styles (single, double, backtick) instead of double-quoted occurrences only.
Test Suite Expansion
test/bin/replacers.spec.ts		 Vitest imports reordered. Four new test cases added for replaceImportsInJsCode_vite covering template literals vs. quoted strings and urlPathname variations (undefined and "/foo-bar-baz/"), validating output on both POSIX and Windows path types.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through code with glee,
Quotes now triple—single, double, tick!
Tests bloom fresh in harmony,
From 11.15.1 to rc so slick,
Asset paths no longer picky! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Rc 1010' is vague and non-descriptive, using only a branch identifier without conveying the actual changes made. Replace with a descriptive title summarizing the main change, such as 'Support single and template-quoted asset paths in Vite import replacer' or 'Fix asset path replacement for single-quoted and template-literal strings'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rc_1010

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@garronej garronej mentioned this pull request Mar 21, 2026
Closed
@garronej
Copy link
Copy Markdown
Collaborator Author

garronej commented Mar 21, 2026

@Oussemasahbeni can you please test keycloakify@11.15.2-rc.1 and confirm it fixes the issue?

@Oussemasahbeni
Copy link
Copy Markdown
Contributor

Oussemasahbeni commented Mar 21, 2026

image hello @garronej its working fine after updating to keycloakify@11.15.2-rc.1

@garronej garronej merged commit ea38534 into main Mar 21, 2026
7 checks passed
@garronej
Copy link
Copy Markdown
Collaborator Author

garronej commented Mar 21, 2026

@allcontributors please add @Oussemasahbeni for code.

@allcontributors allcontributors Bot mentioned this pull request Mar 21, 2026
Merged
@allcontributors
Copy link
Copy Markdown
Contributor

allcontributors Bot commented Mar 21, 2026

@garronej

I've put up a pull request to add @Oussemasahbeni! 🎉

garronej pushed a commit that referenced this pull request Mar 21, 2026
@Oussemasahbeni
Merge pull request #1012 from keycloakify/rc_1010
9db30ea 
Rc 1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garronej @Oussemasahbeni