test: make org.jbpm.kie.services.test.ProcessServiceImplWithoutAuditTest deterministic#2494
Open
Jack-LuoHongyi wants to merge 1 commit into
Open
Conversation
…est deterministic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jbpm-services/jbpm-kie-servicesorg.jbpm.kie.services.test.ProcessServiceImplWithoutAuditTestRoot Cause
DeploymentDescriptorImpl#toXml()relies onHashMapiteration order to materializekie-deployment-descriptor.xml. Under NonDex the XML element order shuffles, the descriptor violates the schema before any test executes, and all 8 targeted methods fail during@Before. Assertions and scenarios never run; the failures are purely from fixture-order randomness.Fix
Replace the dynamic descriptor builder with a static XML string that preserves original semantics (same persistence units, audit mode NONE, runtime strategy SINGLETON, required elements). This keeps assertions and scenarios intact while eliminating nondeterministic ordering in the generated descriptor.
Validation
Validation
QueryServiceImplTest) remains stableRisk
Low. Fixture-only change; descriptor semantics unchanged, assertions preserved, deterministic ordering guaranteed.