1.23.7: feat: performance enhancements#60
Merged
Merged
Conversation
- parser: optimized 'glob' usage by checking for wildcard characters before compiling patterns - parser: optimized 'resolve_variables' to use single-pass scanning instead of repeated string replacements - backup: refactored 'list_backups' and 'perform_backup' to accept optional StyleConfig, preventing redundant config reloading
- config: implement for to adhere to Rust conventions - parser: refactor and to use context structs, reducing argument count and fixing clippy warning - parser: restore corrupted file content and fix syntax errors introduced during optimization attempts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config parser improvements:
src/parser/mod.rsto use aRecursiveParseContextstruct for passing context, improving code clarity and maintainability. Enhanced variable resolution logic to handle overlapping variable names correctly and avoid infinite loops. Improved glob pattern handling and directory sourcing logic for configuration files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]HUD configuration enhancements:
HudPositionenum insrc/config/hud.rsto implement theFromStrtrait for safer string parsing, and replaced the customto_strmethod with the idiomaticas_str. Updated config loading and saving functions to use the new API, improving robustness and correctness. [1] [2] [3] [4]