Skip to content

Update LibGDX to 1.13.5, add TextMapObject to shape extension and add new forEachCell extension#500

Merged
czyzby merged 6 commits into
libktx:developfrom
Quillraven:develop
May 18, 2025
Merged

Update LibGDX to 1.13.5, add TextMapObject to shape extension and add new forEachCell extension#500
czyzby merged 6 commits into
libktx:developfrom
Quillraven:develop

Conversation

@Quillraven

Copy link
Copy Markdown
Contributor

No description provided.

@Quillraven

Copy link
Copy Markdown
Contributor Author

seems like box2d extensions are broken because of the 1.13.5 update. Don't know what has changed there tbh

@Quillraven

Quillraven commented May 17, 2025

Copy link
Copy Markdown
Contributor Author

Box2D test issues are resolved now. I also increased the fault tolerance of the profiling tests. On my machine I had 0.016f as a value which made the test fail. That's why I simply updated the tolerance. Shouldn't be a big deal.


Regarding Box2D:
There were some changes for 1.13.5: libgdx/libgdx#7579
From what I understood you need platform specific natives for that to work which you have per default in a typical LibGDX app. But the tests in KTX were missing that dependency for the tests. Also, since we don't have an ApplicationListener in those tests, we need to manually call GdxNativesLoader.

@Quillraven

Copy link
Copy Markdown
Contributor Author

@czyzby: can you please have a look at the failing github action? I run gradle test on my machine and all tests were passing. So should be fine but the gradle wrapper validation is failing here?

@czyzby

czyzby commented May 18, 2025

Copy link
Copy Markdown
Member

Gradle wrapper validation fails sometimes, I reran the jobs. This should address #499, right? Thanks for submitting a PR for this @Quillraven!

After libGDX updates I tend to bump the version in a couple of additional places like the README (see f45df77), but I can merge this as is and push an extra commit. I'll only ask you to update version.txt in the repository root to 1.13.5-SNAPSHOT so that the latest snapshot release marked 1.13.1-SNAPSHOT is not built against libGDX 1.13.5 as snapshots are pushed automatically. See the contribution guide.

@Quillraven

Copy link
Copy Markdown
Contributor Author

#499 is resolved bis this PR as well, you are correct.

I updated some areas where I found 1.13.1-SNAPSHOT

@czyzby czyzby merged commit 809cc5f into libktx:develop May 18, 2025
2 checks passed
@czyzby

czyzby commented May 18, 2025

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants